...
- follow the KFS Coding Standards (see: KFS Financials Coding Standards)
Communication
A KFS Developer is expected to:
...
- coordinate database changes with a KFS Product Team Engineer
- follow the process outlined in Changes Requiring Pre-Approval and KFS Financials Database Update Procedures for database modification requests and updates
- Have a local database for contribution development (see: Database)
...
- pull updates from the repository prior to committing code, review differences with the repository, and merge changes as necessary
- pull requests should be made at the story level with a single commit (squash commits)
- make sure commits have comments, including . Comments should start with the JIRA # then include a short description and Jira #
- make sure all code compiles prior to submitting a pull request
- make sure the webapp runs and is in good basic working order (does a doc search work? can you create a new document? etc.) prior to submitting a pull request
- make sure the code you're submitting works functionally by testing it in the web application prior to submitting a pull request
- make sure the unit tests pass prior to submitting a pull request (See: Running Unit Tests)
- At a minimum, this means executing the PreCommitSuite to ensure no failures. Failures in this minimal test suite may indicate other developers will be impeded from their development
- If there are unit tests specific to the areas of code being changed in the commit, run those as well, and ensure they pass
- In general, developers don't need to run the full suite of unit tests locally before submitting a pull request, because they are run regularly by our CI serveron each pull request; an exception would be when making a wide sweeping change such as changing from Java 7 to Java 8.
Technical Documentation
A KFS Developer is expected to:
...