...
- pull updates from the repository prior to committing code, review differences with the repository, and merge changes as necessary
- pull requests should be made at the story level with a single commit (squash commits)
- make sure commits have comments. Comments should start with the JIRA # then include a short description
- make sure all code compiles prior to submitting a pull request
- make sure the webapp runs and is in good basic working order (does a doc search work? can you create a new document? etc.) prior to submitting a pull request
- make sure the code you're submitting works functionally by testing it in the web application prior to submitting a pull requestmake sure the unit tests pass prior to submitting
- once you've submitted a pull request, any test failures caused by that pull request are the submitter's responsibility (See: Running Unit Tests)
- At a minimum, this means executing the PreCommitSuite to ensure no failures. Failures in this minimal test suite may indicate other developers will be impeded from their development
- If there are unit tests specific to the areas of code being changed in the commit, run those as well, and ensure they pass In general, developers don't need to run the full suite of unit tests locally before submitting a pull request, because they are run on each pull request; an exception would be when making a wide sweeping change.
Technical Documentation
A Financials Developer is expected to:
...